Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove dead code #4017

Merged
merged 2 commits into from
Nov 26, 2024
Merged

refactor: remove dead code #4017

merged 2 commits into from
Nov 26, 2024

Conversation

ericswanson-dfinity
Copy link
Member

Description

Removes a parameter that is always passes as None. The now-deleted dfx replica command used to pass Some(port).
Then removes the resulting dead code.

How Has This Been Tested?

Refactor covered by CI

@ericswanson-dfinity ericswanson-dfinity requested a review from a team as a code owner November 26, 2024 12:40
@ericswanson-dfinity ericswanson-dfinity merged commit 3200e13 into master Nov 26, 2024
311 of 312 checks passed
@ericswanson-dfinity ericswanson-dfinity deleted the ens/dead-code branch November 26, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants